Add active content warning in jQuery mode #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mossroy I've now tested and debugged this PR in Edge, Firefox ESR, FFOS Simulator, Chromium 66, and IE11 on Windows. It's ready for review. |
|
I quickly tested on Firefox 60 ESR and Chrome 71 : it worked very well ! |
mossroy
reviewed
Jan 11, 2019
mossroy
reviewed
Jan 13, 2019
|
@mossroy I believe remaining issues with this PR are either resolved or pushed to the two new issues I have created. Let me know, by approving the PR, whether it's ready to be squashed/merged. |
mossroy
approved these changes
Jan 13, 2019
Jaifroid
force-pushed
the
Show-active-content-warning-in-jQuery-mode
branch
from
e179c98 to
58c2d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first go at addressing #466. I have backported the UI features and detection of the active content warning from Kiwix JS Windows. It intelligently detects an unsupported UI and puts a yellow Bootstrap
alert-warningjust below the search box. The alert is only shown on the landing page (otherwise it would become very annoying), and is removed when the user presses Config or searches for articles. By default, it will appear again whenever the user goes back to a landing page with active content.The alert can be dismissed temporarily (with the x) or permanently. Hyperlinks to the appropriate settings on the Config page are provided (to activate SW mode, and to hide the warning permanently), and these hyperlinks jump to (and highlight) the setting the user needs to activate. The highlighting feature is backported from Kiwix JS Windows where it is maybe more useful because there are a lot more options that can be confusing. However, it still seems useful here, and educates the user about the Config settings. It also will become more useful as display settings are added.
I've taken the liberty of including a small bit of related code that is part of the same UI feature set in Kiwix JS Windows. It responsively changes the colour of the API status panel from yellow
panel-warning(when the SW API is unavailable or unregistered) to greenpanel-successwhen the SW API is available and registered. I think this makes things clearer for the user and is aesthetically pleasing.